Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ioctl() for tcp wrapper #2600

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

stevenengler
Copy link
Contributor

The forced generic type on TypedPluginPtr::new was useful here since originally I didn't specify it, and since functions like tcp_getInputBufferLength return an i64 and the plugin memory is a i32, it would have overwritten too many bytes without any kind of warning or error. But since TypedPluginPtr::new has the NoTypeInference requirement, it failed to compile.

@stevenengler stevenengler self-assigned this Dec 9, 2022
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 67.83% // Head: 67.30% // Decreases project coverage by -0.52% ⚠️

Coverage data is based on head (5b32478) compared to base (dd7e25f).
Patch coverage: 45.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2600      +/-   ##
==========================================
- Coverage   67.83%   67.30%   -0.53%     
==========================================
  Files         197      197              
  Lines       29097    29115      +18     
  Branches     5733     5737       +4     
==========================================
- Hits        19737    19597     -140     
- Misses       4793     4968     +175     
+ Partials     4567     4550      -17     
Flag Coverage Δ
tests 67.30% <45.00%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/syscall/handler/ioctl.rs 31.25% <ø> (-18.75%) ⬇️
src/main/host/descriptor/socket/inet/tcp.rs 73.01% <45.00%> (-3.40%) ⬇️
src/main/host/descriptor/eventfd.rs 0.00% <0.00%> (-39.40%) ⬇️
src/main/host/syscall/handler/time.rs 29.26% <0.00%> (-36.59%) ⬇️
src/main/host/syscall/handler/eventfd.rs 0.00% <0.00%> (-31.43%) ⬇️
src/main/host/syscall/handler/unistd.rs 55.96% <0.00%> (-9.06%) ⬇️
src/main/host/syscall/handler/mod.rs 78.20% <0.00%> (-3.85%) ⬇️
src/main/host/process.rs 68.75% <0.00%> (-3.13%) ⬇️
src/main/host/memory_manager/memory_mapper.rs 68.94% <0.00%> (-2.70%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevenengler stevenengler merged commit 661e780 into shadow:main Dec 9, 2022
@stevenengler stevenengler deleted the wrap-tcp-rust branch December 9, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Main Composing the core Shadow executable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants