Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Host::setup() #2606

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Conversation

stevenengler
Copy link
Contributor

I wanted to move around some of the host's network objects, but it was a little complicated with the setup() function, so I moved the code from the Host::setup() into Host::new(). Hopefully this doesn't overlap with any other WIP changes.

@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 65.90% // Head: 67.68% // Increases project coverage by +1.77% 🎉

Coverage data is based on head (d0bb8d9) compared to base (270148c).
Patch coverage: 91.83% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2606      +/-   ##
==========================================
+ Coverage   65.90%   67.68%   +1.77%     
==========================================
  Files         198      198              
  Lines       29192    29180      -12     
  Branches     5740     5739       -1     
==========================================
+ Hits        19240    19750     +510     
+ Misses       5420     4858     -562     
- Partials     4532     4572      +40     
Flag Coverage Δ
tests 67.68% <91.83%> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/host.rs 81.41% <91.66%> (+0.46%) ⬆️
src/main/core/manager.rs 63.47% <100.00%> (+0.14%) ⬆️
src/main/host/syscall/handler/random.rs 47.61% <0.00%> (-4.77%) ⬇️
...c/main/utility/synchronization/count_down_latch.rs 85.10% <0.00%> (-0.54%) ⬇️
src/main/host/syscall/handler/socket.rs 66.02% <0.00%> (-0.22%) ⬇️
src/main/utility/byte_queue.rs 56.32% <0.00%> (ø)
src/main/utility/childpid_watcher.rs 69.73% <0.00%> (+0.32%) ⬆️
src/main/host/descriptor/socket/unix.rs 68.15% <0.00%> (+0.34%) ⬆️
src/main/core/support/units.rs 56.36% <0.00%> (+0.51%) ⬆️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sporksmith sporksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@stevenengler stevenengler merged commit 884f478 into shadow:main Dec 13, 2022
@stevenengler stevenengler deleted the move-host-networking branch December 13, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Main Composing the core Shadow executable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants