Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sched_{get,set}affinity bug #2657

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Conversation

stevenengler
Copy link
Contributor

Closes #2625.

@stevenengler stevenengler self-assigned this Jan 11, 2023
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 68.06% // Head: 67.79% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (09da904) compared to base (49c64ee).
Patch coverage: 75.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2657      +/-   ##
==========================================
- Coverage   68.06%   67.79%   -0.28%     
==========================================
  Files         202      202              
  Lines       30100    30112      +12     
  Branches     5855     5856       +1     
==========================================
- Hits        20489    20415      -74     
- Misses       4976     5074      +98     
+ Partials     4635     4623      -12     
Flag Coverage Δ
tests 67.79% <75.75%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/syscall/handler/sched.rs 41.79% <0.00%> (-2.99%) ⬇️
src/main/host/process.rs 83.48% <90.90%> (+0.19%) ⬆️
src/main/host/host.rs 78.01% <91.66%> (+0.41%) ⬆️
src/main/host/thread.rs 79.02% <100.00%> (+0.44%) ⬆️
src/main/host/syscall/handler/eventfd.rs 0.00% <0.00%> (-72.23%) ⬇️
src/main/host/descriptor/eventfd.rs 8.08% <0.00%> (-56.57%) ⬇️
src/main/core/logger/shadow_logger.rs 69.61% <0.00%> (-2.77%) ⬇️
src/main/host/syscall/type_formatting.rs 75.00% <0.00%> (-2.59%) ⬇️
src/main/utility/shm_cleanup.rs 59.09% <0.00%> (-2.28%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/main/host/host.rs Outdated Show resolved Hide resolved
src/main/host/process.rs Outdated Show resolved Hide resolved
All `ProcessId` and `ThreadId` should be convertible to `pid_t` without errors.
These syscall handlers should be searching the thread IDs, not the process IDs.
@stevenengler stevenengler merged commit 40e09ba into shadow:main Jan 12, 2023
@stevenengler stevenengler deleted the fix-getaffinity branch January 12, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Main Composing the core Shadow executable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent regression in launching java under shadow
2 participants