Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log msg level from info to debug #2672

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

stevenengler
Copy link
Contributor

This was changed from debug to info in the rust migration, which causes a slowdown in tor sims and tornettools processing.

This was changed from debug to info in the rust migration, which causes a
slowdown in tor sims and tornettools processing.
@stevenengler stevenengler self-assigned this Jan 18, 2023
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 68.13% // Head: 68.23% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (145ad10) compared to base (98af3c9).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2672      +/-   ##
==========================================
+ Coverage   68.13%   68.23%   +0.09%     
==========================================
  Files         202      202              
  Lines       30305    30305              
  Branches     5917     5917              
==========================================
+ Hits        20648    20678      +30     
+ Misses       4978     4949      -29     
+ Partials     4679     4678       -1     
Flag Coverage Δ
tests 68.23% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/process.rs 79.79% <0.00%> (ø)
src/main/host/syscall/handler/socket.rs 68.64% <0.00%> (-0.85%) ⬇️
src/main/host/descriptor/socket/inet/mod.rs 28.22% <0.00%> (-0.81%) ⬇️
src/main/host/descriptor/pipe.rs 83.75% <0.00%> (-0.63%) ⬇️
src/main/host/syscall/handler/eventfd.rs 69.44% <0.00%> (ø)
src/main/host/host.rs 80.82% <0.00%> (+0.17%) ⬆️
src/main/host/memory_manager/memory_mapper.rs 71.63% <0.00%> (+0.20%) ⬆️
src/main/core/support/units.rs 56.62% <0.00%> (+0.25%) ⬆️
src/main/core/manager.rs 64.74% <0.00%> (+0.44%) ⬆️
src/main/host/syscall/handler/fcntl.rs 65.71% <0.00%> (+1.42%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevenengler stevenengler merged commit 5989e24 into shadow:main Jan 18, 2023
@stevenengler stevenengler deleted the fix-log-msg-lvl branch January 18, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Main Composing the core Shadow executable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants