Simplify the host's networking cleanup #2697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the host's
net_ns: RefCell<Option<NetworkNamespace>>
tonet_ns: NetworkNamespace
by adding aNetworkNamespace::cleanup
function that has to be run while the worker has an active host. The network namespace objects have also been wrapped in aRefCell
. The network interface objects don't have any&mut
methods so thisRefCell
isn't currently needed, but we'll likely want to give them&mut
methods in the future.@robgjansen This can be merged either before or after your changes, whichever makes it easier for your PR.