-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rust listeners on C LegacyFile
s
#2715
Conversation
Codecov ReportBase: 67.03% // Head: 67.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
==========================================
+ Coverage 67.03% 67.85% +0.82%
==========================================
Files 203 203
Lines 30513 30507 -6
Branches 5970 5963 -7
==========================================
+ Hits 20454 20701 +247
+ Misses 5375 5113 -262
- Partials 4684 4693 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
80e7065
to
3870453
Compare
Runtime performance and memory usage seems to be slightly worse in a tor benchmark. I'm not sure why the memory usage appears worse. The simulation network results did not change. https://github.com/shadow/benchmark-results/tree/master/tor/2023-02-07-T20-06-50 |
This should allow us to add rust state/status listener callback closures to `LegacyFile`s in the future.
f9f4493
to
e2543c9
Compare
This is a follow-up to #2715.
This should allow us to add rust state/status listener callback closures to
LegacyFile
s in the future. This means that we can write rust objects that add listeners toLegacyFile
s. For example, we can write a rust epoll file object that listens for events on CTCP
orRegularFile
objects using rust closures.