SysCallHandler: don't store pointers to Process and Thread #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still has the MemoryCopier depending on the Worker and its active Process, but a little better than having to ~incorrectly change the current active thread just to be able to pass its native tid to the MemoryCopier.
This removes circular references, which otherwise complicate the C->Rust migtration of Thread.
sporksmith
force-pushed
the
drop-syscallhandler-ptrs
branch
from
6cc124e
to
60625e8
Compare
|
Queued a benchmark since this is somewhat hot-path https://github.com/shadow/benchmark/actions/runs/4118911692 |
stevenengler
approved these changes
Feb 8, 2023
|
Benchmark results are a hair slower than the last nightly, but within the confidence interval of the weekly. https://github.com/shadow/benchmark-results/blob/master/tor/2023-02-08-T04-41-19/plots/run_time.png |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These circular references otherwise somewhat complicate migrating Thread to Rust.
To facilitate getting rid of these, I added back
worker_getCurrentProcessandworker_getCurrentThread. These are easier to implement safely now that they are wrapped inRootedRcobjects, and we aren't trying to provide mutable access to the Rust objects. I tentatively still think it's better to prefer passing explicitly where possible, particularly in Rust code, but these are helpful in C code and for interop with C code during the migration.