Changes to some rust syscall handlers #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Main
I think it makes more sense to set the `SysCallCondition`s active file at the top-level of each syscall handler rather than putting it in helpers. This means that we don't need to pass the `OpenFile` all the way through, and means that any helpers or the file methods don't need to worry about setting this themselves when they want to return a blocking `SyscallError`.
stevenengler
force-pushed
the
readv-writev
branch
from
3dff9ea
to
3005990
Compare
sporksmith
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves some code around, and moves where we set a syscall condition's active file. This is to prepare for supporting readv/writev/sendmsg/recvmsg.