Restructure Socket to use sendmsg and recvmsg
#2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Libraries
stevenengler
force-pushed
the
readv-writev
branch
from
a39ab51
to
67d682d
Compare
The flag we were using as an invalid flag in this test is actually a flag for 32-bit compatibility (MSG_CMSG_COMPAT). Most of the 32 bits of the int are actual flags and more might be added in the future, so it would be brittle to try and test an unused one. I think it's best to just not test this.
This replaces `Socket::sendto` and `Socket::recvfrom` with `Socket::sendmsg` and `Socket::recvmsg`.
stevenengler
force-pushed
the
readv-writev
branch
from
67d682d
to
c952bd9
Compare
github-actions
bot
added
the
Component: Testing
sporksmith
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't add support for the
sendmsgandrecvfromsyscalls, but restructures the socket code so that we can support these syscalls in the future. When reviewing the changes, it might be easier to ignore whitespace changes by appending?w=1to the URL on github.