Cleanup syscall_types import redirection #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup a dangling TODO after moving some syscall_types to from the `main` crate to the `shadow_shim_helper_rs` crate to change all `use` statements to use the new location directly instead of using a `pub use` in the old location.
github-actions
bot
added
the
Component: Main
In previous discussion we agreed in theory on rustfmt's `StdExternalCrate` grouping policy. Unfortunately we currently can't use this in our default config, since it only works on nightly. This is a one-time run of rustfmt using that policy with the nightly compiler. It cleans up the ordering both from the previous commit (which was semi-automated using sed) and everywhere else.
github-actions
bot
added
Component: Libraries
stevenengler
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup a dangling "XXX temp" TODO after moving some syscall_types to from the
maincrate to theshadow_shim_helper_rscrate to change allusestatements to use the new location directly instead of using apub usein the old location.Also do a one-time global automated cleanup of rust import grouping.