Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not implicitly search current directory for executables #2824

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Do not implicitly search current directory for executables #2824

merged 1 commit into from
Apr 3, 2023

Conversation

sporksmith
Copy link
Contributor

This is a planned breaking change for the Shadow 3.0 release. See #2496 and #2447 (comment).

This forces users to explicitly use "./" to specify a binary in the current directory.

@github-actions github-actions bot added Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks labels Mar 31, 2023
@sporksmith
Copy link
Contributor Author

Not quite ready yet after all; forgot to run the --extra tests locally

@sporksmith sporksmith removed the request for review from stevenengler March 31, 2023 21:17
@github-actions github-actions bot added Component: Build Build/install tools and dependencies Component: Tools Peripheral tools like parsing log files or visualizing results labels Mar 31, 2023
@sporksmith
Copy link
Contributor Author

Tests passing now, with #2825 cherry-picked in. I'll plan to merge #2825 first and then drop that commit from this PR.

@github-actions github-actions bot removed Component: Tools Peripheral tools like parsing log files or visualizing results Component: Build Build/install tools and dependencies labels Apr 3, 2023
@sporksmith
Do not implicitly search current directory for executables
2eadb63 
This is a planned breaking change for the Shadow 3.0 release.
See shadow#2496 and
shadow#2447 (comment).

This forces users to explicitly use "./" to specify a binary in the
current directory.
@sporksmith sporksmith enabled auto-merge (squash) April 3, 2023 15:33
@sporksmith sporksmith merged commit 5efe48f into shadow:main Apr 3, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@sporksmith sporksmith

Labels
Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks
Projects
None yet
Milestone
Code health and maintenance
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sporksmith @stevenengler