Reduce usage of special environment variables #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Documentation
stevenengler
approved these changes
Apr 10, 2023
sporksmith
force-pushed
the
use-less-env
branch
from
e2291e8
to
dc009d3
Compare
Instead of migrating this from an env variable to shared memory, we can just remove it. This optimization has been working reliably.
There's no sense in maintaining these since they should always be handled in the shim. We don't want to unexpectedly end up calling one of these at runtime, since behavior may diverge from the shim-side handling down the road.
sporksmith
force-pushed
the
use-less-env
branch
from
dc009d3
to
739e1a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the environment variables SHADOW_DISABLE_SHIM_SYSCALL, SHADOW_SHM_PROCESS_BLK, and SHADOW_SHM_HOST_BLK.
As part of removing SHADOW_DISABLE_SHIM_SYSCALL, this also removes the experimental option
use_shim_syscall_handler, and removes the redundant shadow-side syscall handlers.Progress on #2848