Small latch improvements #2867
Merged
Small latch improvements #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fine since the latch can only be used in the same process.
github-actions
bot
added
the
Component: Main
stevenengler
commented
Apr 12, 2023
sporksmith
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the atomic from
AtomicI32toAtomicU32since I realized that futex(2) in ubuntu 20.04 is out of date, and newer man pages show that its unsigned.This also adds
FUTEX_PRIVATE_FLAGwhich may improve performance (but I doubt it will in practice). This flag can be used since the latch will only ever be used in the same process.