Process: remove circular weak reference #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Main
sporksmith
force-pushed
the
remove-process-circ-ref
branch
3 times, most recently
from
125a1ef
to
0dd8a77
Compare
stevenengler
approved these changes
Apr 17, 2023
Passing the outer ProcessRefCell wrapper to C code was primarily to help with an intermediate state where some of Process was still in C. It also allowed us to potentially catch more conflicting borrow errors at runtime, but these shouldn't be an issue in practice since the C code no longer stores these pointers.
Specifically this will let us change the Worker::set_active_process API to take a RootedRefCell<RefCell<Process>>, without needing a circular reference in Process. Later this will also be a good place to handle some of Process teardown when the Process exits.
This removes usage of the circular weak reference inside Process.
This makes the interface consistent with Worker::set_active_process, and simplifies the implementation.
sporksmith
force-pushed
the
remove-process-circ-ref
branch
from
0dd8a77
to
70246e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks some further cleanup of managing Process's internal state, and removes some complexity in itself.