Remove the '_manager_heartbeat' string #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Main
sporksmith
approved these changes
Apr 17, 2023
Tornettools shouldn't search for this string anymore as of shadow/tornettools#96.
stevenengler
force-pushed
the
remove-old-hearbeat-str
branch
from
9557df9
to
06802f7
Compare
stevenengler
added a commit
to stevenengler/shadow
that referenced
this pull request
Apr 19, 2023
This broke in shadow#2874.
stevenengler
added a commit
that referenced
this pull request
Apr 19, 2023
This broke in #2874. This bug prevents the benchmark runner from generating tgen runtime performance graphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tornettools shouldn't search for this string anymore as of shadow/tornettools#96. Part of the 3.0 changes.