Replace hosts file with a memfd #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The temporary hosts file is now cleaned up immediately instead of at the end of the simulation, which prevents littering the user's /tmp with hosts files when Shadow crashes.
Now we don't write anything to the filesystem.
github-actions
bot
added
the
Component: Main
sporksmith
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Cool! I wonder if we could do the same with the memory files created by the shmem allocator and the MemoryMapper.
I think at one time we thought it might be useful to have the files around later to inspect when debugging, but I don't think they've been useful in practice.
I think so, and one benefit would be that we wouldn't run into issues due to a small /dev/shm mount as we do now in Docker containers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that Shadow's fake hosts file isn't written to the filesystem and won't clutter /tmp with hundreds of files.