Make Process's strace file shareable across Processes #2971
Conversation
github-actions
bot
added
Component: Libraries
When we fork a Process, the child will use the same strace file (if any). This is analogous to `strace -f`. Progress on shadow#1987.
| strace_logging: Option<StraceLogging>, | ||
| // strace logging file, if any. Shared with forked Processes. | ||
| strace_logging: Option<RootedRc<RootedRefCell<StraceLogging>>>, |
There was a problem hiding this comment.
I think this would be simpler by just cloning/duping (File::try_clone) the file instead of sharing it?
There was a problem hiding this comment.
Thanks, that sounds much simpler :)
| strace_logging: Option<StraceLogging>, | ||
| // strace logging file, if any. Shared with forked Processes. | ||
| strace_logging: Option<RootedRc<RootedRefCell<StraceLogging>>>, |
There was a problem hiding this comment.
Why is the RootedRefCell needed? I don't think we need to mutate the format options at runtime, and the file is already inside a RefCell. If it's needed for Send/Sync or something, maybe replace the RefCell in StraceLogging with RootedRefCell instead?
There was a problem hiding this comment.
Right, otherwise the inner RefCell can't go inside the RootedRc, since it's not Sync. I'll take a look at replacing the inner RefCell instead if File::try_clone doesn't work out.
sporksmith
modified the milestones:
Support missing syscalls,
Support shell-style spawning and management of processes
|
Obsoleted by adding |
When we fork a Process, the child will use the same strace file (if any). This is analogous to
strace -f.Progress on #1987.