Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_tests workflow: add sccache #3127

Merged
merged 5 commits into from
Aug 25, 2023
Merged

run_tests workflow: add sccache #3127

merged 5 commits into from
Aug 25, 2023

Commits on Aug 25, 2023

  1. run_tests workflow: use sccache

    @sporksmith
    sporksmith committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5880c20 View commit details
    Browse the repository at this point in the history

  2. Remove run_tests_incremental workflow 

    This is redundant with the "run_tests" workflow, which is now just as
fast since adding sccache.
    @sporksmith
    sporksmith committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    543efbd View commit details
    Browse the repository at this point in the history

  3. extra_tests: disable cargo incremental compilation 

    * Incremental builds don't help here
* sccache won't cache incrementally compiled crates
* this is also set in the "run_tests" workflow, where the corresponding
  configuration shares cache with this job. Using different
  configurations may cause the caches to be incompatible (i.e. cause
  cache misses)
    @sporksmith
    sporksmith committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5a5780f View commit details
    Browse the repository at this point in the history

  4. Replace SCCACHE_RECACHE with SCCACHE_CACHE_VERSION 

    I don't think SCCACHE_RECACHE would have worked as intended in this
scenario. It tells the sccache server to reset its cache, but the CI
wouldn't have written back the cache anyway since the cache key didn't
change.

Instead we can increment SCCACHE_CACHE_VERSION to force new caches to be
saved.
    @sporksmith
    sporksmith committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5d33bc9 View commit details
    Browse the repository at this point in the history

  5. CI: align restore-keys with corresponding key above

    @sporksmith
    sporksmith committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    27d7235 View commit details
    Browse the repository at this point in the history