Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the build time of the tests #3304

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

stevenengler
Copy link
Contributor

@stevenengler stevenengler commented Mar 11, 2024

When building the tests we also build extra stuff that we don't need, for example the linux-api C bindings. This PR reduces the build time of the tests from 66 seconds to 42 seconds (207 compilation units to 150) when built with ./setup build --test, as documented in the report from cargo build --timings. The next most problematic crates are the linux-api, vasi-sync, formatting-nostd/toml-edit, and neli crates due to their use of syn and related proc macros, but there's not much we can do about those.

Partial graph of the time taken by the test crates after this PR:

1710128104_grim

Since linux-api doesn't rely on rustix and only adds some extra `From` impls
between linux-api and rustix types, I think this would be better as a
non-default feature.
@stevenengler stevenengler self-assigned this Mar 11, 2024
@github-actions github-actions bot added Component: Libraries Support functions like LD_PRELOAD and logging Component: Testing Unit and integration tests and frameworks Component: Main Composing the core Shadow executable Component: Build Build/install tools and dependencies labels Mar 11, 2024
Copy link
Contributor

@sporksmith sporksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/lib/linux-api/build.rs Outdated Show resolved Hide resolved
This feature doesn't seem to be needed anymore now that the standard library
has a backtrace module. Enabling this feature pulls in the backtrace crate even
though it's not needed.

Backtraces are still supported when you use `RUST_BACKTRACE=1`.
To be more consistent.
@stevenengler stevenengler merged commit df2db4a into shadow:main Mar 11, 2024
24 checks passed
@stevenengler stevenengler deleted the tests-compile-speed branch March 12, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Build/install tools and dependencies Component: Libraries Support functions like LD_PRELOAD and logging Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants