-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the build time of the tests #3304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since linux-api doesn't rely on rustix and only adds some extra `From` impls between linux-api and rustix types, I think this would be better as a non-default feature.
0e65e03
to
1ef00ed
Compare
sporksmith
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This feature doesn't seem to be needed anymore now that the standard library has a backtrace module. Enabling this feature pulls in the backtrace crate even though it's not needed. Backtraces are still supported when you use `RUST_BACKTRACE=1`.
To be more consistent.
1ef00ed
to
043fde2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Build
Build/install tools and dependencies
Component: Libraries
Support functions like LD_PRELOAD and logging
Component: Main
Composing the core Shadow executable
Component: Testing
Unit and integration tests and frameworks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the tests we also build extra stuff that we don't need, for example the linux-api C bindings. This PR reduces the build time of the tests from 66 seconds to 42 seconds (207 compilation units to 150) when built with
./setup build --test
, as documented in the report fromcargo build --timings
. The next most problematic crates are the linux-api, vasi-sync, formatting-nostd/toml-edit, and neli crates due to their use of syn and related proc macros, but there's not much we can do about those.Partial graph of the time taken by the test crates after this PR: