Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lseek syscall on pipes #3320

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Support lseek syscall on pipes #3320

merged 1 commit into from
Apr 1, 2024

Conversation

stevenengler
Copy link
Contributor

lseek() on a pipe should return ESPIPE. I just added a C test in the existing file.c since it was simplest and keeps the lseek tests in one place.

@stevenengler stevenengler added this to the Support missing syscalls milestone Apr 1, 2024
@stevenengler stevenengler self-assigned this Apr 1, 2024
@github-actions github-actions bot added Component: Testing Unit and integration tests and frameworks Component: Main Composing the core Shadow executable labels Apr 1, 2024
sporksmith
sporksmith approved these changes Apr 1, 2024
View reviewed changes
src/main/host/syscall/handler/file.rs Outdated Show resolved Hide resolved
@stevenengler stevenengler merged commit 3f3468a into shadow:main Apr 1, 2024
23 checks passed
@stevenengler stevenengler deleted the seek-pipe branch April 1, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels
Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks
Projects
None yet
Milestone
Support missing syscalls
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevenengler @sporksmith