Fix CI dependencies #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing both zlib and zlib-devel, dnf thinks that we want the best possible version of both packages. This is a problem if the best versions of zlib and zlib-devel are incompatible. Instead, we should install the best version of zlib-devel, and use whatever zlib version is compatible with that. Also removed some other packages where we also specify devel versions.
sporksmith
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing both zlib and zlib-devel, dnf thinks that we want the best possible version of both packages. This is a problem if the best versions of zlib and zlib-devel are incompatible (centos has fixed a security vulnerability in zlib but didn't bother updating zlib-devel). Instead, we should install the best version of zlib-devel, and use whatever zlib version is compatible with that. Also removed some other packages where we also specify devel versions.