Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModularPart with zero volume causes NRE #738

Closed
shadowmage45 opened this issue Sep 18, 2018 · 1 comment
Closed

ModularPart with zero volume causes NRE #738

shadowmage45 opened this issue Sep 18, 2018 · 1 comment

Comments

@shadowmage45
Copy link
Owner

ST-HAB-A1 with default configuration causes the following exceptions in the log when the 'configure containers' button is pressed:

[EXC 11:28:16.391] NullReferenceException: Object reference not set to an instance of an object
	SSTUTools.VolumeContainerGUI.updateGuiData ()
	SSTUTools.SSTUVolumeContainer.OnGUI ()

Switching even one of the end-caps to something else with volume, and the error does not occur. Switching back to the zero-volume endcap after the GUI is open does not cause an error, so the run-time bits of the system have no problem with zero volume, only the setup/initialization routines have issues.

Likely cause is that the container data is not being constructed, as it has zero volume, and thus nothing is presented to the GUI to display/manipulate.

As there is no (easy/simple/robust) way to disable the GUI opening button in the stock PAW, the robable solution is to instantiate UI-side containers even for zero-volume setups.

@shadowmage45
Copy link
Owner Author

Fixed in dev -- window will properly refuse to open if no containers are available.

Investigating alternate fix to display a blank/empty window, or at least pop an error message regarding no available containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant