Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the snap desktop file #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

come-maiz
Copy link

This will skip the manual review when uploading the snap to the store.

@come-maiz
Copy link
Author

We have just committed a few changes related to the desktop file: https://bugs.launchpad.net/snapcraft/+bug/1588359
They will land in the next snapcraft release, which will make it nicer dealing with desktop files. We can improve it next week, but for now this will unblock the automatic releases to the store.

@kewde
Copy link

kewde commented Jan 5, 2017

Thanks @ElOpio, I'm assuming you have tested these changes?

Copy link

@kewde kewde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@come-maiz
Copy link
Author

hey @kewde. Thanks for taking a look. Yes, I tested it. Now when I open the unity menu, shadow appears with its icon :)

@popey
Copy link

popey commented Jan 26, 2017

Now that snapcraft 2.25 (latest) implemented a fix for the above bug, can shadow be re-built and submitted to the store?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants