Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance disabled convar #48

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brandonsturgeon
Copy link
Contributor

This PR fixes a few cases where players' prop2mesh_disable convar is ignored.

Will stay in Draft status until I can test it properly, but I'm happy to receive reviews in the meantime.

@shadowscion
Copy link
Owner

shadowscion commented Jan 17, 2023

Can you elaborate? The entire thing was probably unnecessary to begin with but the way I envisioned the two convars working together was "server convar has to be true for client convar to do anything". It was supposed to be a middle ground between build servers and competitive servers where disabling might give one a visual advantage. I wouldn't be opposed to removing the server setting altogether if it's causing issues.

@brandonsturgeon
Copy link
Contributor Author

On our build server, people are frustrated that they disable P2M but still receive and process mesh data. The system you implemented allows server owners the ability determine if a player can actually turn off P2M - that works fine, but these two net.Broadcast calls don't respect the clientside convar and sends the data to all clients regardless of if they have P2M turned off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants