-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin lib 1.3.0 #2245
Plugin lib 1.3.0 #2245
Conversation
Please read doc for METADATA_KEY_EXECUTABLE_PATH for more details. Basically, we get around application launching limitations from Huawei (among others) by reading metadata and therefore prevent launching the application altogether. This should hopefully fix #1091, #1106. (requires plugin app support) This commit also refines error reporting in PluginManager.
For client see: shadowsocks/v2ray-plugin-android@6c58c30#diff-c8cc2dd42271f2bf39c6aa81eb6a5529R25 (luckily this does not require the release of 1.3.0 lib) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yeah, I'm using Huawei Mate 20. I think #1091 is already fixed by Huawei on Android P. Also tested latest commit. Everything works well. |
Hmm... According to Crashlytics (5c93a35af8b88c2963f27cf3), this still happens and >1/3 of them are Android 9 devices (including a Huawei Honor Play and Honor V9). This issue also non-negligibly occurs for vendors including ADVAN, EVERCROSS, vivo, LENOVO among others. |
Before 1.3:
After killing plugin app proc and installing updated apps, |
Plugin lib 1.3.0
Read commit messages for more information. Tested locally with updated v2ray-plugin-android that I will push later.
This should hopefully fix #1091 and #1106 but I have not tested since I do not own a device that can reproduce them.