Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin lib 1.3.0 #2245

Merged
merged 5 commits into from Jun 22, 2019

Conversation

@Mygod
Copy link
Contributor

commented Jun 19, 2019

Read commit messages for more information. Tested locally with updated v2ray-plugin-android that I will push later.

This should hopefully fix #1091 and #1106 but I have not tested since I do not own a device that can reproduce them.

Mygod added 3 commits Jun 19, 2019
Please read doc for METADATA_KEY_EXECUTABLE_PATH for more details.
Basically, we get around application launching limitations from Huawei (among others) by reading metadata and therefore prevent launching the application altogether.
This should hopefully fix #1091, #1106. (requires plugin app support)

This commit also refines error reporting in PluginManager.
@Mygod Mygod added the enhancement label Jun 19, 2019
@Mygod Mygod requested a review from madeye Jun 19, 2019
@Mygod Mygod added the plugin label Jun 19, 2019
@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

For client see: shadowsocks/v2ray-plugin-android@6c58c30#diff-c8cc2dd42271f2bf39c6aa81eb6a5529R25 (luckily this does not require the release of 1.3.0 lib)

Mygod referenced this pull request in shadowsocks/v2ray-plugin-android Jun 20, 2019
@madeye
madeye approved these changes Jun 20, 2019
Copy link
Contributor

left a comment

LGTM

@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

@madeye Do you have a Huawei device that can test #1091?

@madeye

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

Yeah, I'm using Huawei Mate 20. I think #1091 is already fixed by Huawei on Android P.

Also tested latest commit. Everything works well.

@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

Hmm... According to Crashlytics (5c93a35af8b88c2963f27cf3), this still happens and >1/3 of them are Android 9 devices (including a Huawei Honor Play and Honor V9). This issue also non-negligibly occurs for vendors including ADVAN, EVERCROSS, vivo, LENOVO among others.

@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

Before 1.3:

I/ActivityManager: Start proc 23494:com.github.shadowsocks.plugin.v2ray/u0a382 for content provider com.github.shadowsocks.plugin.v2ray/.BinaryProvider

After killing plugin app proc and installing updated apps, ActivityManager no longer outputs Start proc line so I have high confidence that this should resolve the issue.

@Mygod Mygod merged commit e6b511f into master Jun 22, 2019
2 of 3 checks passed
2 of 3 checks passed
ci/circleci CircleCI is running your tests
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
License Compliance All checks passed.
Details
@Mygod Mygod deleted the plugin-1.3.0 branch Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.