Fix windows build failed and allowed build under msys2 or cygwin #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SquallATF
force-pushed
the
windowsbuild
branch
3 times, most recently
from
1bf6b67
to
62fe0f3
Compare
Mygod
reviewed
May 10, 2021
Mygod
approved these changes
May 11, 2021
|
I have create a patch for rust plugin mozilla/rust-android-gradle#59 |
|
That would be even better! |
|
@madeye Huh I was waiting them to merge mozilla/rust-android-gradle#59 |
|
Hmm... revert? |
|
It's ok. I don't really care about building on Windows anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2666 #2711
if linker arguments too long, rust will use response file link.rs#L1178, then output filename detect will failed.
Under msys2 and cygwin
RUST_ANDROID_GRADLE_CCshould convert to unix path when use native python.Under msys2 and cygwin environment the response file will convert to full arguments when run under winshell, so need convert linker arguments back to response file to avoid
Argument list too long