Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛔ config: deny unknown fields #1106

Merged

Conversation

database64128
Copy link
Contributor

No description provided.

@dev4u
Copy link

dev4u commented Feb 4, 2023

这个会收获一拨小白

@zonyitoo
Copy link
Collaborator

zonyitoo commented Feb 4, 2023

We may have to close the “issue” tab for a month :)

@zonyitoo zonyitoo merged commit 29991bc into shadowsocks:master Feb 4, 2023
@database64128
Copy link
Contributor Author

Then they'll just start flooding Discussions. 😄

Jokes aside, sing-box and my proxy projects all do this, and only one of my projects got this one issue, and it's most likely they used unknown fields only because the Go standard library's JSON serializer cannot deserialize JSON documents with comments, which was never an issue for shadowsocks-rust.

@database64128 database64128 deleted the config-deny-unknown-fields branch February 4, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants