Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_nodelay and set_keepalive #123

Merged
merged 1 commit into from
Sep 23, 2018
Merged

Add set_nodelay and set_keepalive #123

merged 1 commit into from
Sep 23, 2018

Conversation

eataix
Copy link
Contributor

@eataix eataix commented Aug 16, 2018

These additions are similar to those in 271e24d, which were then
removed during the transition to futures and tokio in 5bf6560.

These additions are similar to those in 271e24d, which were then
removed during the transition to futures and tokio in 5bf6560.
@zonyitoo
Copy link
Collaborator

I don't think it is a good idea to set_nodelay. Because we uses streaming protocol assembling, which means that we may call send multiple times while assembling a single protocol header (shadowsocks' protocol header).

@sorz
Copy link

sorz commented Sep 18, 2018

+1 for TCP keepalive
This should be the correct implementation for dead connection detection.
"copy timeout" may better to be disable or have a large value (like dozens hours).

@zonyitoo zonyitoo merged commit 38b2df6 into shadowsocks:master Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants