Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to 2021 version of rust instead of 2018 version. #655

Merged
merged 2 commits into from Oct 25, 2021
Merged

Updated to 2021 version of rust instead of 2018 version. #655

merged 2 commits into from Oct 25, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2021

No description provided.

@database64128
Copy link
Contributor

Could you please stop spamming useless PRs and issues and not waste everybody's time? This is not how you participate in open source projects. I took a brief look at your past activities in some popular repositories on GitHub. Many of your opened issues and PRs just demonstrate your lack of basic technical skills and common sense (in programming).

@ghost
Copy link
Author

ghost commented Oct 25, 2021

Did i hurt your feelings or something?

I don't know who u are or what I have done to you but sorry dude whatever I did or said, I don't think this is about a PR.

@database64128
Copy link
Contributor

@Prajwal-Koirala By opening a useless PR like this, you’re wasting everybody’s time. It’s nothing personal.

@ghost
Copy link
Author

ghost commented Oct 25, 2021

How is this useless?

Rust came out with a new version 2021.

@ghost
Copy link
Author

ghost commented Oct 25, 2021

@database64128
Copy link
Contributor

@Prajwal-Koirala Yes, we all know the 2021 edition is now in the stable channel. That doesn’t mean you can just go to an actively-maintained Rust project, bump the language version, without any meaningful prior contribution. This is not how open source works.

@zonyitoo
Copy link
Collaborator

It seems that there is nothing have to be migrated when switching from 2018 to 2021. What would we get if we switch to 2021?

According to the migration guide: https://doc.rust-lang.org/edition-guide/rust-2021/index.html , we have no benefit except (maybe) the disjoint capture in closures.

@zonyitoo zonyitoo merged commit 68521d5 into shadowsocks:master Oct 25, 2021
@ghost ghost deleted the patch-1 branch October 25, 2021 08:25
@ghost
Copy link
Author

ghost commented Oct 25, 2021

@Prajwal-Koirala Yes, we all know the 2021 edition is now in the stable channel. That doesn’t mean you can just go to an actively-maintained Rust project, bump the language version, without any meaningful prior contribution. This is not how open source works.

I can't even describe how stupid you are, just don't bother responding.

@shadowsocks shadowsocks locked as off-topic and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants