fixed buildExcludes options not working

[ihavecoke]

Fixed buildExcludes option not working at all

Here are some source code,

next-pwa

exclude: [
  ({ asset, compilation }) => {
    if (asset.name.match(/^(build-manifest\.json|react-loadable-manifest\.json|server\/middleware-manifest\.json|server\/middleware-runtime\.js|_middleware\.js|server\/pages\/_middleware\.js)$/)) {
      return true
    }
    .....
    return false
  },
  ...buildExcludes
]

exclude options first element is function type, when pass to workbox-webpack-plugin apply checkCondition function. it always match first if condition. so that your buildExcludes with some string strategy or regex strategy will not match at all. on the other words buildExcludes not effect.

below is workbox-webpack-plugin source code

function checkConditions(asset, compilation, conditions = []) {
    for (const condition of conditions) {
        if (typeof condition === 'function') {
            return condition({ asset, compilation });
            //return compilation !== null;
        }
        else {
            if (webpack_1.ModuleFilenameHelpers.matchPart(asset.name, condition)) {
                return true;
            }
        }
    }
    // We'll only get here if none of the conditions applied.
    return false;
}

[garganurag89]

Hi @shadowwalker ,
Thanks for this fix. Can you please release this I need this in my project to exclude the source maps file?

[shadowwalker]

This is either a bug for while or workbox changed some of the code on their end.

[garganurag89]

Hi @shadowwalker ,
, is missing after buildExcludes in line number 197. Kindly add that as well.

[shadowwalker]

Yeah, I fixed locally.

[shadowwalker]

Published 5.4.6

[garganurag89]

Thanks a lot