Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to get Change object when subscribing to Observable* collections #5

Closed
thekalinga opened this issue Aug 2, 2018 · 8 comments

Comments

@thekalinga
Copy link
Contributor

thekalinga commented Aug 2, 2018

Currently, this library consumes the most important information about the changes that happened in the underlying library

For example, if I have a dynamic tree whose children can be added & removed dynamically & I want to expose this information to a TreeView, each node needs to know what changes happened to the child ObservableLists & in what position. This position information can never be accessed because the library swallows this information & only emits a subset of the this important information

For eg., for ObservableList currently I can only get

  1. A new ObservableList via Flux<ObservableList<T>> from(ObservableList<T> source)
  2. Only the added elements via Flux<T> fromAdditionsOf(ObservableList<T> source)
  3. Only removed elements via Flux<T> fromRemovalsOf(ObservableList<T> source)

Instead the user should get the full power of underlying *Change (ListChangeListener.Change incase of ObservableList) objects. This way user will know what happened & most importantly where in the underlying child Observable*

This has to be applied to every Observable* collection as the library should never hinder the user from getting the underlying raw information if the user needs it as my above example demonstrates it

@thekalinga
Copy link
Contributor Author

thekalinga commented Aug 2, 2018

Unlike ObservableList/ObservableSet/ObservableMap, ArrayChangeListener does not have a change object. So a ReactorFx specific Change object needs to be created for each change event thats pushed downstream

@thekalinga
Copy link
Contributor Author

thekalinga commented Aug 2, 2018

I'm currently making the required changes to the code. Will submit a pull request

@thekalinga
Copy link
Contributor Author

Pull request sent. Can you plz review & accept pull request if fix is good enough

Thanks

@thekalinga
Copy link
Contributor Author

@shadskii Can you please review the pull request

shadskii added a commit that referenced this issue Aug 21, 2018
@thekalinga
Copy link
Contributor Author

@shadskii Thanks for merge. Can you publish new version to maven central aswell. I only see 1.8.0 there

@thekalinga
Copy link
Contributor Author

@shadskii Can u publish a new version to maven central

@shadskii
Copy link
Owner

Yes I had an issue with my previous computer that had the private key for uploading to maven on it. I am in the process of recovering it and I should have the new version up in a day or two :)

Sorry for the delay and thanks for your patience!

Jake

@shadskii
Copy link
Owner

Version 2.0.0 has been published to maven central. Thank you for your contribution!

Cheers,

Jake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants