Try to make integration tests pass

[sethmlarson]

Trying to make integration tests pass for now while we work towards a way of handling the HTTP lifecycle.

[sethmlarson]

@shadycuz Btw you'll have to approve running workflows since this is the first time I'm contributing to your repository ;)

[shadycuz]

@sethmlarson let me know when you want this merged.

I'll try to look through it tomorrow.

[shadycuz]

@sethmlarson Is there something I can do to speed this along? The boto tests are fixed, but not requests.

I see your new config block:

if self._response_options is None:
    raise ResponseNotReady()

Is killing the request tests, it seems they call getresponse() directly and not the urlib3.request mixin. I'm not sure what I can do to help, but I will look and see how they are passing the "response_kwargs", but it's likely they were just taking advantage of the default values and possibly not passing any?

[shadycuz]

Okay so if its not chunked, then they call conn.urlopen() and if it is chunked they seem to be doing all the work manually?

https://github.com/psf/requests/blob/bda7f0171f8bba17989d3a2c28dfa9a9261b1b65/requests/adapters.py#L488-L528

But even if we didn't break getresponse(), they very next call is HTTPResponse.from_httplib() which has been removed 🤔

https://github.com/psf/requests/blob/bda7f0171f8bba17989d3a2c28dfa9a9261b1b65/requests/adapters.py#L531-L539

[sethmlarson]

@shadycuz Oh dang, forgot that Requests was using all those low-level APIs. Going to work with @nateprewitt to see if we can move Requests away from using these since they'll be going away in v2.0 anyways.

[sethmlarson]

An update on this: chatted with @nateprewitt and he agreed to change the function to use our chunking instead of custom code in Requests. Once that is changed this PR should begin working.

Are you okay with reviewing or merging this PR @shadycuz?

[shadycuz]

@sethmlarson I have already reviewed, I didn't understand everything, but I understood most.