Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rent Home Now API: Implimentation v1 #42

Merged
merged 120 commits into from
May 18, 2023
Merged

Rent Home Now API: Implimentation v1 #42

merged 120 commits into from
May 18, 2023

Conversation

shahadat3669
Copy link
Owner

@shahadat3669 shahadat3669 commented May 18, 2023

Rent Home Now API: V1

Project Requirements

Note: Front End PR Request

  • Add Rswag API engine for API documentation at the '/api-docs' endpoint.
  • Creates RESTful routes for the following resources
    • The 'categories' resource with only the 'index' and 'show' actions available.
    • The 'properties' resource with the 'index', 'show', 'create', 'update', and 'destroy' actions available.
    • The 'reservation_criterias' resource with the same set of actions.
    • The 'addresses' resource, but only allows the 'create', 'update', and 'destroy' actions.
    • The 'users' resource with the 'index', 'show', 'update', and 'destroy' actions available.
    • The 'reservations' resource with the same set of actions.
  • Add user authentication using jwt
  • Add rspec test cases for model and controllers

Here is our ER Diagram:

image

Swagger Ui demo

image

General requirements

@shahadat3669 shahadat3669 marked this pull request as ready for review May 18, 2023 17:18
@shahadat3669 shahadat3669 added the enhancement New feature or request label May 18, 2023
Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shahadat3669,

Wow, you did it 🎉

Brilliant

Thank you for the changes implemented 💪 🥇 ㊗️

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! 🎉

applause

To highlight

  • API is working well✔️
  • Tests are passing✔️
  • Nice code implementation✔️
  • Nice routes, models, controllers ✔️
  • Good validations ✔️
  • Robust, functional seeds.rb file ✔️
  • Awesome, superb job ✔️

Cheers and Happy coding!👏👏👏


@shahadat3669 shahadat3669 merged commit b0033a6 into main May 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants