Increase tap surface for start and end handles

[JBerendes]

The trimmer works if can tap and get ahold of the shaded area to the left of the start or to the right of the end. When it starts it's likely at 0. Obviously grabbing something with 0 width is hard. It takes about 3 to 5 tries to get ahold of the left trimmer and even more for the right one. Is there a way to increase the hitslop of these? Would anyone else find it worthwhile to add a handleHitslop property?

[JBerendes]

i can help if you want to point me at a good place to start looking. If you would rather do it I can help with the pull request.

[shahen94]

@JBerendes i've added 20 points hitSlop around right and left corners, so it should help
293741c#diff-6c03c8e763c79ed4239a829fdd8a7f9dR59

[JBerendes]

testing now

[JBerendes]

It doesn't seem to have been solved. The video starts several seconds after I have been trying to grab the starting trimmer ... Then when I'm moving it more fluidly it's because I'm grabbing the shaded area.

[shahen94]

Well try to change that line which I've pointed

[JBerendes]

My thought is that the area offered as touchable is not larger than what is visible. So any touch events that occur to the left of the white start trimmer are not seen because they are outside of the parent container.

I'll try what you just mentioned. Thanks

[JBerendes]

I see, we need access to a thumbWidth prop so it can be passed to ICGVideoTrimmerView.m On smaller devices it's simply to narrow at the default value.

[shahen94]

great, look how we provide all props to JS side, in similar way you can also pass thumbsWidth prop

[JBerendes]

will do.

[shahen94]

Released https://github.com/shahen94/react-native-video-processing/releases/tag/v1.5.0

[JBerendes]

looks good.