Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] fix boomerang issue which causes video taken by back camera to be rotated #257

Merged
merged 3 commits into from
Oct 24, 2019

Conversation

BaderSerhan
Copy link
Contributor

As the title suggests, this PR fixes the following iOS issue: applying the boomerang effect on a video recorded via the back camera causes the video to be displayed rotated by 90 degrees.

I added a prop cameraType which indicates the type of camera currently used to record the video, either front or back, so that the fix only applies to the back camera. By default, the camera is set to back.

I tested this in my project and it is working correctly.

@shahen94 shahen94 merged commit 93a7741 into shahen94:master Oct 24, 2019
@shahen94
Copy link
Owner

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants