Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attendances #42

Merged
merged 3 commits into from Feb 16, 2022
Merged

Attendances #42

merged 3 commits into from Feb 16, 2022

Conversation

Ehsan-sudo
Copy link
Collaborator

  • api routes organized on alphabetic order
  • attendance issue finished. check the route ":8000/attendances/find-by-subject-period/{subject_id}/{period_id}/" to get all the students filtered by subject and period.

@Ehsan-sudo Ehsan-sudo linked an issue Feb 16, 2022 that may be closed by this pull request
Attendance (Querying Analysis) #7
Closed
shahghasiadil
shahghasiadil requested changes Feb 16, 2022
View reviewed changes
Copy link
Owner

@shahghasiadil shahghasiadil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change getStudentsBySubjectPeriod parameters to
Request $request
and call $requset->subject_id

shahghasiadil
shahghasiadil requested changes Feb 16, 2022
View reviewed changes
Copy link
Owner

@shahghasiadil shahghasiadil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Subject Code to Subject Migration , Model, Controller

shahghasiadil
shahghasiadil approved these changes Feb 16, 2022
View reviewed changes
Copy link
Owner

@shahghasiadil shahghasiadil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@shahghasiadil shahghasiadil merged commit fc02e95 into master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahghasiadil shahghasiadil shahghasiadil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attendance (Querying Analysis)
2 participants
@Ehsan-sudo @shahghasiadil