Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better name parsing for facebook groups #95

Open
lrudolph333 opened this issue Feb 13, 2024 · 5 comments
Open

better name parsing for facebook groups #95

lrudolph333 opened this issue Feb 13, 2024 · 5 comments

Comments

@lrudolph333
Copy link
Contributor

Hey this is an issue I resolved and would like to commit to your open-source project.

Right now your package only groups the first user name on a given facebook page. This is fine for pages but terrible for groups, which always have many posts from many users.

I added support for grabbing the author names from every post in a FB group, instead of just the first author on a FB page.

Is this an open source project, or will my solution be only available to me?

@shaikhsajid1111
Copy link
Owner

Hi @lrudolph333, I assume you've made changes in your local copy of this repository. This project is open to changes that brings improvements. If you want to make changes to this repository from your local changes, feel free to push those changes to new branch and raise a Pull Request

@GabrielMunarriz
Copy link

Hi @lrudolph333! I've been looking for a fix for this issue as I am trying to use this project for facebook groups instead of facebook pages. I hope you can share the changes you made soon!

@lrudolph333
Copy link
Contributor Author

@shaikhsajid1111 I have these changes committed locally, however I don't have permission to push or create branches on this repo. I'm getting a 403 error when I attempt either of these, who are you allowing pushes from on this repo? You may have to adjust the repo settings.

@shaikhsajid1111
Copy link
Owner

@lrudolph333 Others can raise PR. Can you please share how're you trying it?

@lrudolph333
Copy link
Contributor Author

lrudolph333 commented Mar 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants