Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Allow editing the source face for Bend or Extend feature #32

Closed
normandc opened this issue May 6, 2018 · 5 comments
Closed

[FR] Allow editing the source face for Bend or Extend feature #32

normandc opened this issue May 6, 2018 · 5 comments

Comments

@normandc
Copy link

normandc commented May 6, 2018

It would be useful to re-attribute a bend or extend feature to a different face ID after its creation. Due to FreeCAD's topological naming issue, if changes are made to a bend's properties (like gap1 and gap2) that changes the number of faces it generates, then following operations will likely fail or produce unexpected results after a recompute. An editing option would allow the end user to repair failed features.

This is a recent example where editing bends would be useful: FreeCAD forum - Sheet Metal bending

Thanks.

@shaise
Copy link
Owner

shaise commented May 7, 2018

I Agree this is a good feature. I will take a look at it as soon as I have time.

@shaise
Copy link
Owner

shaise commented Jun 25, 2018

Done on version 0.1.20

@shaise shaise closed this as completed Jun 25, 2018
@normandc
Copy link
Author

Thank you! I was trying to find this in the Data tab, but just now realized that you only need to double-click on the Bend feature in the Model tree to open a dialog.

@normandc
Copy link
Author

I just noticed, following issue #37 that if I have a model with Bend, Bend001 and Bend002, and I delete Bend001, then Bend002 fails. I was expecting to be able to edit Bend002 and reattribute a face to it, but I'm getting the following error:

Traceback (most recent call last): File "/home/normand2/.FreeCAD/Mod/sheetmetal/SheetMetalCmd.py", line 373, in setEdit taskd.update() File "/home/normand2/.FreeCAD/Mod/sheetmetal/SheetMetalCmd.py", line 429, in update if isinstance(f[1],list): <type 'exceptions.TypeError'>: 'NoneType' object has no attribute '__getitem__' Exception (Sat Jul 28 13:05:15 2018): getEditDialog() not implemented

@shaise
Copy link
Owner

shaise commented Jul 28, 2018

when you delete a parent bend the next bend have no base object to work with, hence I guess it fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants