fix: Fix log window focus

Without a popup, we can just directly open the window from the background script. In this context, we have permission to focus a window. Fixes #23 Change-Id: I572c71fb65a9b5ac71e9d6afd1d04cefbe650eed
shaka-project · Nov 12, 2021 · 8d09fea · 8d09fea
1 parent 86c72c0
commit 8d09fea
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 58 deletions.
diff --git a/log-window.js b/log-window.js
@@ -267,9 +267,15 @@ function prettyPrint(obj, indentation = '') {
  * Listens for messages from the content script to append a log item to the
  * current frame and log file.
  */
-if (chrome.runtime) {
-  chrome.runtime.onMessage.addListener((request, sender, sendResponse) => {
-    const log = request.log;
-    EmeLogWindow.instance.appendLog(log);
-  });
-}
+chrome.runtime.onMessage.addListener((request, sender, sendResponse) => {
+  const log = request.log;
+  EmeLogWindow.instance.appendLog(log);
+});
+
+/**
+ * When the extension icon is clicked, open the log window if it doesn't exist,
+ * and bring it to the front otherwise.
+ */
+chrome.browserAction.onClicked.addListener((tab) => {
+  EmeLogWindow.instance.open();
+});
diff --git a/log.html b/log.html
@@ -15,6 +15,7 @@
 -->
 <html>
   <head>
+    <title>EME Logger</title>
     <script src="log.js"></script>
     <style>
 #clear-button {

diff --git a/manifest.json b/manifest.json
@@ -25,8 +25,7 @@
     "scripts": ["log-window.js"]
   },
   "browser_action": {
-    "default_title": "EME Logger",
-    "default_popup": "popup.html"
+    "default_title": "EME Logger"
   },
   "web_accessible_resources": [
     "trace-anything.js",

diff --git a/popup.html b/popup.html
diff --git a/popup.js b/popup.js