Skip to content

Commit

Permalink
fix(chromeos): Fix loading of node-fetch library (#87)
Browse files Browse the repository at this point in the history
node-fetch is an ES module, and you can't require() ESM from a non-ESM
script. I'm not sure when this changed, or with what versions of node
and this package it used to work, but downgrading to node-fetch v2 gives
us the non-ESM version that works.
  • Loading branch information
joeyparrish committed May 14, 2024
1 parent 8620037 commit 85b4ccf
Show file tree
Hide file tree
Showing 2 changed files with 53 additions and 114 deletions.
165 changes: 52 additions & 113 deletions backends/chromeos/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backends/chromeos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
"dependencies": {
"generic-webdriver-server": "^1.1.5",
"node-fetch": "^3.3.2",
"node-fetch": "^2.7.0",
"node-ssh": "^13.2.0",
"yargs": "^17.7.2"
},
Expand Down

0 comments on commit 85b4ccf

Please sign in to comment.