Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter fails on Windows due to line endings #33

Closed
joeyparrish opened this issue Feb 14, 2022 · 1 comment · Fixed by #34
Closed

Linter fails on Windows due to line endings #33

joeyparrish opened this issue Feb 14, 2022 · 1 comment · Fixed by #34
Assignees
@joeyparrish
Labels
platform: Windows Issues affecting Windows status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@joeyparrish
Copy link
Member

.gitattributes needs to be set up so that code is checked out with consistent line endings on Windows.
@joeyparrish joeyparrish added type: bug Something isn't working correctly platform: Windows Issues affecting Windows labels Feb 14, 2022
@joeyparrish joeyparrish self-assigned this Feb 14, 2022
@joeyparrish
Copy link
Member Author

Actually, I think instead of enforcing LF line endings on all users through .gitattributes, I should just configure git that way in the workflow. That way, each user/developer can configure git how they prefer.

@joeyparrish joeyparrish mentioned this issue Feb 14, 2022
Merged
joeyparrish added a commit that referenced this issue Feb 15, 2022
@joeyparrish
ci: Fix linter errors on Windows (#34)
8939cc5 
Configure git in the test workflow to check out code with LF line
endings on Windows, so that we pass linter checks.

Also, the linter only needs to run at the top-level package, and the
top-level config covers all backends.

Fixes #33
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Apr 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
platform: Windows Issues affecting Windows status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Fix linter errors on Windows
1 participant
@joeyparrish