Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document requirements for iframe embedding for Chromecast receiver #7

Closed
joeyparrish opened this issue Sep 2, 2020 · 1 comment
Closed
Assignees
Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation

Comments

@joeyparrish
Copy link
Member

Sites can prevent iframe-embedding with the X-Frame-Options header. Though this should not be an issue for a test runner, one of the first things a person might try with the command-line tools is:

chromecast-webdriver-cli --hostname=chromecast-hostname --url=https://www.google.com/

However, google.com prevents iframe embedding, which means it cannot be shown in our Chromecast receiver. The user would see a blank screen instead. This should be clearly documented to avoid confusion.

@joeyparrish joeyparrish added the type: docs Improvements or fixes to documentation label Sep 2, 2020
@joeyparrish joeyparrish self-assigned this Sep 2, 2020
@joeyparrish
Copy link
Member Author

And in fact, we use www.google.com as an example in README.md, in spite of the fact that Google Search blocks iframe embedding. This was a particularly bad choice for the docs of this backend.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 28, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation
Projects
None yet
Development

No branches or pull requests

2 participants