Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix hung launcher on shutdown of Safari #38

Merged
merged 2 commits into from
Apr 20, 2022

Commits on Apr 19, 2022

  1. fix: Fix hung launcher on shutdown of Safari

    In some cases (notably macOS Safari under GitHub Actions), a call to
    forceKill() would be triggered during another call to forceKill().
    This could cause the second Promise to go unresolved, leading to a
    hang.  On GitHub, eventually, the workflow would be cancelled.
    
    This fixes the nested calls to forceKill by making them both resolve
    on the same event (the shutdown triggered by the first call).
    
    This also adds a timeout for shutting down a WebDriver session.
    Although this does not appear to be the root cause of the hang we
    were experiencing in GitHub Actions workflows, it should be safer to
    have this timeout.  If we can't stop a WebDriver session gracefully,
    we will timeout after 5s and end the launcher anyway.
    joeyparrish committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    43be149 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Configuration menu
    Copy the full SHA
    b010b4f View commit details
    Browse the repository at this point in the history