Skip to content

Commit

Permalink
fix: Fix NPM binary publication (#1371)
Browse files Browse the repository at this point in the history
The default .npmignore would disallow bin/, which contains binaries for
our NPM release. Every release before v3.0.3 was missing .npmignore, and
therefore had no binaries. These were unusable in NPM, and have been
marked as deprecated because of it.

Closes #1369
  • Loading branch information
joeyparrish committed Mar 12, 2024
1 parent d83c7b1 commit 4cb6536
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/publish-npm.yaml
Expand Up @@ -44,7 +44,6 @@ jobs:
uses: actions/checkout@v4
with:
ref: ${{ inputs.tag }}
submodules: recursive

- uses: actions/setup-node@v4
with:
Expand Down
8 changes: 8 additions & 0 deletions npm/.npmignore
@@ -0,0 +1,8 @@
# This file is required for us, even if empty.
#
# The default .npmignore would disallow bin/, which contains binaries for our
# NPM release. Every release before v3.0.3 was missing .npmignore, and
# therefore had no binaries. These were unusable in NPM, and have been marked
# as deprecated because of it.
#
# See also https://github.com/shaka-project/shaka-packager/issues/1369
1 change: 1 addition & 0 deletions npm/prepublish.js
Expand Up @@ -14,6 +14,7 @@ var commandNames = {
},
darwin: {
'x64': 'packager-osx-x64',
'arm64': 'packager-osx-arm64',
},
win32: {
'x64': 'packager-win-x64.exe',
Expand Down

0 comments on commit 4cb6536

Please sign in to comment.