Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support seek pre-roll in more audio codecs including AAC #452

Closed
kqyang opened this issue Aug 21, 2018 · 1 comment
Closed

Support seek pre-roll in more audio codecs including AAC #452

kqyang opened this issue Aug 21, 2018 · 1 comment
Assignees
@kqyang
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.3

Comments

@kqyang
Copy link
Collaborator

kqyang commented Aug 21, 2018

Right now Shaka Packager supports seek pre-roll in Opus only. The seek pre-roll in other audio codecs are ignored with a warning message:

Unexpected seek preroll for codec ...

FFmpeg added support for seek pre-roll in AAC recently. We should support seek pre-roll in AAC too.
@kqyang kqyang added the type: enhancement New feature or request label Aug 21, 2018
@kqyang kqyang added this to the v2.3 milestone Aug 21, 2018
@kqyang kqyang self-assigned this Aug 21, 2018
kqyang added a commit that referenced this issue Sep 17, 2018
@kqyang
Add support for seek preroll in AAC and other audio codecs
3cf9b91 
Closes #452.

Change-Id: I0f648c4fa6c861540b050a5b4e9878987c8383e5
@kqyang
Copy link
Collaborator Author

kqyang commented Sep 17, 2018

Cherry-picked to v2.2.1.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 23, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kqyang kqyang

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.3
Development

No branches or pull requests
2 participants
@kqyang @shaka-bot