feat: CMake port media/trick_play #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdanek
force-pushed
the
cmake_media_trickplay3
branch
from
d13994a
to
46d4c9f
Compare
joeyparrish
requested changes
Nov 30, 2022
|
I made several updates to the PR, and merged in other changes from the cmake branch. The build fails on Windows due to linker errors, but I'm not sure why yet. |
|
Working on this again. Debugging the Windows linker errors from the Shaka lab's Windows machine. I suspect a misconfiguration of protobuf somehow. It appears that absl is linked with a different MSVC runtime than what protoc's main.cc wants to use, which leads to the linker error. |
joeyparrish
approved these changes
May 1, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1047 (CMake porting)