docs: start updating docs for CMake #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmin
changed the title
|
I'm pushing a few edits. PTAL when you can. If you approve of my edits, feel free to merge. |
joeyparrish
approved these changes
Oct 17, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a pass at updating the build docs for Linux and Mac and Windows.
I also started updating the Linux profiling docs to remove references to things that don't work anymore. We can take another pass at that after actually integrating
gperftoolsinto CMake. Likewise for adding easy to use build modes for various sanitizers.I propose we leave the
gperftoolsand sanitizers enhancements to the build for after the merge ofcmakeintomainsince it's holding up feature and bug fixes. And we can continue to iterate on the build system.