Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: http_file: Close upload cache on task exit #1348

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fix: http_file: Close upload cache on task exit #1348

merged 1 commit into from
Feb 23, 2024

Commits on Feb 21, 2024

  1. fix: http_file: Close upload cache on task exit 

    In some cases it can happen that the http server responds with a
non-successful status code without reading the response body. In this
case curl may decide not to read from the cache since there is really no
point in sending data to the server. In case some other thread of shaka
has already called HttpFile::Flush it may end up deadlocked there
waiting for the cache to either close or become empty. Thus, we close
the cache when leaving the main thread as no data will be read by curl
after it has finished anyways.
    @petzeb
    petzeb committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    07cba4c View commit details
    Browse the repository at this point in the history