fix: Break header installation for the shared library #1407
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I started the tests for this... why did you close it? |
|
Hi Joey,
Sorry I made a wrong manip. I reopened it.
Zaki
On May 30, 2024, at 10:31 PM, Joey Parrish ***@***.***> wrote:
I started the tests for this... why did you close it?
—
Reply to this email directly, view it on GitHub<#1407 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AR4JL6YBTG7ORU4K6KWWI5DZE6ECDAVCNFSM6AAAAABIRR3JOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQHAYTMNZWGI>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
I edited your PR and added the necessary line (file.h) to packager.h to make sure the |
|
Thx for your help. Very appreciated.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Joey Parrish ***@***.***>
Sent: Thursday, May 30, 2024 10:45:16 PM
To: shaka-project/shaka-packager ***@***.***>
Cc: zaki699 ***@***.***>; State change ***@***.***>
Subject: Re: [shaka-project/shaka-packager] fix: Break header installation for the shared library (PR #1407)
I edited your PR and added the necessary line (file.h) to packager.h to make sure the packager_link_test target can catch macros/classes.h being missing.
—
Reply to this email directly, view it on GitHub<#1407 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AR4JL64O6O4SZANFAMX3P23ZE6FVZAVCNFSM6AAAAABIRR3JOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQHAZTKOBYGA>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Happy to help. That check really should have caught this, and I created it, so it was the least I could do. |
|
I think the CLA is not working because my git configuration was not setting up correctly and was using the wrong email and user.
Do you mind telling me what to do to fix this ?
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Joey Parrish ***@***.***>
Sent: Thursday, May 30, 2024 10:53:06 PM
To: shaka-project/shaka-packager ***@***.***>
Cc: zaki699 ***@***.***>; State change ***@***.***>
Subject: Re: [shaka-project/shaka-packager] fix: Break header installation for the shared library (PR #1407)
Happy to help. That check really should have caught this, and I created it, so it was the least I could do.
—
Reply to this email directly, view it on GitHub<#1407 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AR4JL65B4ONLTFALU43SJXDZE6GTFAVCNFSM6AAAAABIRR3JOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQHA2DMOJUHE>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Sure. I'm going to the "Details" link next to the CLA check at the bottom of the PR. There, I see a list of the contributors from the git commits:
So it's the commit from |
zaki699
force-pushed
the
Fix-macros-classes-include-file
branch
from
1ef5981
to
042e60f
Compare
|
Ok Now the CLA is validated. Thx |
|
It seems that I have somehow managed to remove your previous commit. Do you mind pushing it again ? Thanks you |
This allows our link test to catch missing header dependencies for file.h. An audit of all public headers was conducted, and file.h was the only one not referenced in packager.h.
|
Done |
|
I will merge this if the tests pass, which I fully expect |
include/file.h is breaking header installation for the shared library build. macros/classes.h must be included to the public headers.
Closes #1406