Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paused video doesn't react on changing device orientation #194

Open
kareljuricka opened this issue Nov 25, 2020 · 0 comments · May be fixed by #199
Open

Paused video doesn't react on changing device orientation #194

kareljuricka opened this issue Nov 25, 2020 · 0 comments · May be fixed by #199
Labels
type: bug Something isn't working correctly
Milestone
v1.1

Comments

@kareljuricka
Copy link
Contributor

Issue description

I'm listening UIDevice.orientationDidChangeNotification to recalculate player view frame on orientation changed.
On each change, I call:

self.playerView.frame = self.view.bounds;

where self.playerView is ShakaPlayerView instance.

If video is PLAYING, this approach works correctly.

But when video is PAUSED, last image of paused video is rotated but its dimensions aren't recalculated..
Dimensions aren't recalculated until I start to play video again.

ScreenShot

After rotate from landscape to portrait when player paused:
Wrong behavior
IMG_7059

Expected behavior
IMG_7060
kareljuricka added a commit to kareljuricka/shaka-player-embedded that referenced this issue Nov 27, 2020
@kareljuricka
Fixing paused video doesn't react on changing device orientation
581e317 
Fixes shaka-project#194
@kareljuricka kareljuricka linked a pull request Nov 27, 2020 that will close this issue
Open
@TheModMaker TheModMaker added the type: bug Something isn't working correctly label Nov 30, 2020
kareljuricka added a commit to kareljuricka/shaka-player-embedded that referenced this issue Nov 30, 2020
@kareljuricka
Fixing paused video doesn't react on changing device orientation with…
8d55cb8 
…out overhead

Fixes shaka-project#194
@shaka-bot shaka-bot added this to the v1.1 milestone Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Fixing paused video doesn't react on changing device orientation kareljuricka/shaka-player-embedded
3 participants
@TheModMaker @kareljuricka @shaka-bot